ITP-JAN-25 | EYUEL_ABRAHAM| | Module-Onboarding Feature/wireframe | Week 1 #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
halilibrahimcelik
added
Review in progress
halilibrahimcelik
suggested changes
Jan 26, 2025
|
|
||
| <div class="bottom-side"> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> |
There was a problem hiding this comment.
Can you tell me why we have to use alt tags in img elements, please do not forget to fill alt tags in images
| <p> | ||
| Code your future 2024. | ||
| </p> | ||
| </div> |
There was a problem hiding this comment.
Footer position is fixed but you should also show footer's background, if not user can't clearly see where footer starts and also due to z-index problem, it creates barrier for user to click on read more button if you scroll to top, please refers to these issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.